Parametrize timeout in .wait_for() call#973
Open
alexberndt wants to merge 1 commit intotestcontainers:mainfrom
Open
Parametrize timeout in .wait_for() call#973alexberndt wants to merge 1 commit intotestcontainers:mainfrom
alexberndt wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Member
|
ok so better if we can add this to the base strategy class, because you can have other parameters, like interval and frequency. if you must add this now, mark it as deprecated with a note that this will be a common field in all strategies in the future. like we can even keep this parameter around indefinitely because ergonomics is important but architecturally it is out of place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parametrize the timeout time in the
DockerCompose().wait_for()method, sticking to the original default of120seconds.